search

containernetworking / cni

Container Network Interface - networking for Linux containers
https://cni.dev
Apache License 2.0
5.49k stars 1.08k forks source link

want to contribute macvtap plugin + mesos delegate plugin #674

Open f1-outsourcing opened 5 years ago

f1-outsourcing commented 5 years ago

Can I have chat with someone on contributing 2 plugins. For now it should add functionality that you can use a macvtap, which has little different use than the macvlan. Adding proper routing to network namespace so the mesos agent/slave is able to contact the task. Furthermore the mesos delegate allows 'runtime' configuration via the parsed org.apache.mesos-network_info. I will write some docs, so you can understand exactly why this could be useful to have.

f1-outsourcing commented 5 years ago

https://github.com/f1-outsourcing/plugins/tree/master/plugins/main/macvtap

https://github.com/f1-outsourcing/plugins/blob/master/plugins/main/macvtap/macvtap-routing.md

dcbw commented 5 years ago

@f1-outsourcing I think the macvtap plugin is definitely interesting; would you mind filing a PR against the https://github.com/containernetworking/plugins repo with the code? Thanks!

Not sure yet about the mesos delegate; let's just start with the macvtap one.

Could you update your macvtap plugin based on the latest macvlan code in the plugins repo? For example we have cleaned things up so you don't have to do this anymore:

            os.Setenv("CNI_COMMAND", "DEL")
            ipam.ExecDel(n.IPAM.Type, args.StdinData)
            os.Setenv("CNI_COMMAND", "ADD")
bboreham commented 5 years ago

Related: #316

bboreham commented 3 years ago

I came across another macvtap plugin: https://github.com/kubevirt/macvtap-cni