search

containernetworking / plugins

Some reference and example networking plugins, maintained by the CNI team.
Apache License 2.0
2.14k stars 775 forks source link

Support DeviceID on Auxiliary Bus #1003

Closed adrianchiris closed 4 months ago

adrianchiris commented 6 months ago

Device plugins may allocate network device on a bus different than PCI.

sriov-network-device-plugin supports the allocation of network devices over Auxiliary bus[1][2][3].

extend host-device CNI to support such devices if provided through runtime config.

[1] https://github.com/k8snetworkplumbingwg/sriov-network-device-plugin/tree/master?tab=readme-ov-file#auxiliary-network-devices-selectors [2] https://github.com/k8snetworkplumbingwg/sriov-network-device-plugin/tree/master/docs/subfunctions [3] https://docs.kernel.org/networking/devlink/devlink-port.html

adrianchiris commented 5 months ago

@squeed golangci-lint version bumped in gh actions which causes lint failure (not related to this PR)

submitted #1009 to keep version fixed so that CI is stable (version bumps IMO should occur periodically in controlled manner, i.e submitting PR)

s1061123 commented 5 months ago

@squeed PTAL again?

s1061123 commented 5 months ago

@adrianchiris hi, CI (Lint) has some error. Could you please take a look into it?

adrianchiris commented 5 months ago

@adrianchiris hi, CI (Lint) has some error. Could you please take a look into it?

@s1061123 we should merge : #1009 then ill rebase this one and we should be good.

the lint issues not related to this PR but rather because linter version bumped in CI.

adrianchiris commented 4 months ago

Rebased on top of main. CI is green.

@s1061123 @s1061123 PTAL on this one :)