search

containernetworking / plugins

Some reference and example networking plugins, maintained by the CNI team.
Apache License 2.0
2.23k stars 788 forks source link

plugin version unknown (1.4.1 release) #1019

Closed tristanmorgan closed 6 months ago

tristanmorgan commented 8 months ago

Hi, The latest builds (1.4.1) of the CNI plugins are not printing the plugin versions when run. I've tested both x86_64 and Arm64 packages. I suspect changes in the build process since 1.4.0 release missed setting BuildVersion.

# /opt/cni/bin/dummy 
CNI dummy plugin version unknown
CNI protocol versions supported: 0.1.0, 0.2.0, 0.3.0, 0.3.1, 0.4.0, 1.0.0
maxadamo commented 7 months ago

This is going to create problems to other tools: https://github.com/GEANT/nomad_cni/blob/main/lib/facter/nomad_cni_version.rb#L10

I hope you could delete and reissue this version.

FibreFoX commented 6 months ago

Or just release 1.4.2 instead of re-publishing, maybe to address #1033 too

antoninbas commented 6 months ago

+1 This script is no longer used for releases: https://github.com/containernetworking/plugins/blob/main/scripts/release.sh As a result, github.com/containernetworking/plugins/pkg/utils/buildversion.BuildVersion is no longer set using linker flags.

squeed commented 6 months ago

@s1061123 can you take a look? I know you worked on automated release building.

squeed commented 6 months ago

In the mean time, I'll re-build the release with the version set properly.

squeed commented 6 months ago

Rebuilt the release, PTAL

s1061123 commented 6 months ago

@squeed I got that script misses build version (ldflags in release.sh script). Will fix that soon.

s1061123 commented 6 months ago

@squeed https://github.com/containernetworking/plugins/pull/1037 fixes the issue. PTAL?