containernetworking / plugins

Some reference and example networking plugins, maintained by the CNI team.
Apache License 2.0
2.12k stars 773 forks source link

Pass status along ipam #1050

Open maiqueb opened 1 month ago

maiqueb commented 1 month ago

This PR bumps the plugins to use CNI 1.2.0 and allows delegating the STATUS verb to IPAM plugins.

This way, other CNI plugins implementing STATUS can delegate the STATUS calls to IPAM CNIs.

squeed commented 1 month ago

@LionelJouin very good point. Do you think this affects more than just tests? I'm not sure if there's anything that embeds types.NetConf that also marshal to disk. But, we probably need to revert https://github.com/containernetworking/cni/pull/1039

LionelJouin commented 1 month ago

Could be. I created a ticket for it: https://github.com/containernetworking/cni/issues/1096 SBR (flaking) and tuning plugins are also failing, but I haven't checked the reason yet.