bridge: add support for setting vlans as pvid and untagged

containernetworking / plugins

Some reference and example networking plugins, maintained by the CNI team.

Apache License 2.0

2.23k stars 788 forks source link

bridge: add support for setting vlans as pvid and untagged #936

Closed bersoare closed 1 year ago

bersoare commented 1 year ago

This PR adds support for specifying a PVID and untagged vlans for a trunk. Added new checks for the presence of these attributes in the tests, as well as a new test case that uses the newly introduced values.

bersoare commented 1 year ago

hello @s1061123 ,

thanks for the suggestions, indeed changing it to be a []VlanTrunk makes sense to keep it consistent. just changed it, all tests passed locally. let me know what you think.

thank you!

s1061123 commented 1 year ago

@bersoare sorry but let me ask you why the PR close? I suppose the almost design seems to be reasonable. Currently CNI community focus on new CNI spec hence we don't have time to review PRs yet, but I'd like to push this PR....