search

containernetworking / plugins

Some reference and example networking plugins, maintained by the CNI team.
Apache License 2.0
2.17k stars 778 forks source link

Why not expose netlin.LinkAttrs in parameter to config queue number of veth pair？ #940

Open victory460 opened 1 year ago

victory460 commented 1 year ago

https://github.com/containernetworking/plugins/blob/9d9ec6e3e18ea245b9cef0f8396e570247338d1f/pkg/ip/link_linux.go#L34-L39

Why not expose netlin.LinkAttrs in parameter to config queue number of veth pair？ like this code:

func makeVethPair(linkAttr netlink.LinkAttrs, peer string, mac string, hostNS ns.NetNS) (netlink.Link, error) {
    veth := &netlink.Veth{
        LinkAttrs:     linkAttr,
        PeerName:      peer,
        PeerNamespace: netlink.NsFd(int(hostNS.Fd())),
    }

we want to config rx queue number of veth pair.

ruicao93 commented 8 months ago

@victory460 what are the benifits of using multiple queue numbers for a veth device?