containers-everywhere / contain-google

[Looking for maintainer] - Google Container isolates your Google activity from the rest of your web activity in order to prevent Google from tracking you outside of the Google website via third party cookies.
https://addons.mozilla.org/en-US/firefox/addon/google-container/
Mozilla Public License 2.0
407 stars 51 forks source link

Whitelist some sites for the container #54

Open tlaundal opened 5 years ago

tlaundal commented 5 years ago

When logging into my google account with OneLogin, the login process hangs if I have this extension enabled.

My workaround is this:

I believe this process could be streamlined by allowing the onelogin domain to stay in the container when opened from the container. I believe the risk involved in this is very low.

I do not think OneLogin should be hard coded in the application, but that we rather should accept a whitelist of domains that are allowed to stay inside the container from settings.

I can create a PR for this in a while.

herpiko commented 5 years ago

I think there is no need for whitelist. We can make it works by defining some oauth related paths that need to be available to perform such login. Make it an option just like Ignore Youtube.

tlaundal commented 5 years ago

I do not believe your PR will fix this issue, as this relates to logging into Google with SSO. As for the whitelist: I believe it makes more sense to let a few third party sites into the google container, than to let a few google URI out of the container.

situplastik commented 3 years ago

Totally agree with @tlaundal . Here an issue asking for the same #113

situplastik commented 3 years ago

PR #114 resolve that problem @Perflyst