containers / BuildSourceImage

Tool to build a source image based on an existing OCI image
GNU General Public License v2.0
29 stars 14 forks source link

ensure testing for the containerbuild use-case #57

Closed vbatts closed 4 years ago

vbatts commented 4 years ago

their use of bsi: https://github.com/containerbuildsystem/atomic-reactor/blob/master/atomic_reactor/plugins/build_source_container.py#L69 their use of skopeo: https://github.com/containerbuildsystem/atomic-reactor/blob/master/atomic_reactor/plugins/post_tag_and_push.py#L74

vrothberg commented 4 years ago

their use of bsi: https://github.com/containerbuildsystem/atomic-reactor/blob/master/atomic_reactor/plugins/build_source_container.py#L69

Covered in https://github.com/containers/BuildSourceImage/blob/master/test/01-from_rpms.bats#L10

their use of skopeo: https://github.com/containerbuildsystem/atomic-reactor/blob/master/atomic_reactor/plugins/post_tag_and_push.py#L74

I am confident in Skopeo's testing, but I'll add a test covering exactly those use cases to make sure our image is fully functional.