*: remove building from a remote image reference

[vbatts]

This internally used skopeo to fetch a remote image, which had design issues with how to handle auth.

Now the recommendation is to:

• directly use skopeo to fetch skopeo copy docker://... oci:./...
• unpack the image layout ./BuildSourceImage.sh ./src/ ./dest
• TODO pass this ./dest/ relative-root to the downloader plugin?
• then build as usual from this content

Signed-off-by: Vincent Batts vbatts@hashbangbash.com

[vbatts]

For sure. I did have a branch that ripped it all out in one go, but it got a bit messed up, so I'm going piecemeal. I could just make this a wip PR for all of it, and layer commit at a time for each aspect. But that begins looking like individual PRs anyways.

On Wed, Mar 4, 2020, 04:49 Valentin Rothberg notifications@github.com wrote:

@vrothberg commented on this pull request.

I wonder if we need the same for pushing?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/containers/BuildSourceImage/pull/71?email_source=notifications&email_token=AAAQL2KRGAZA3Y4R7GG7SXTRFYP3HA5CNFSM4LARDRX2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCX4OYHI#pullrequestreview-368634909, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAQL2IU7I6HZRI7JSHXR3DRFYP3HANCNFSM4LARDRXQ .

[vrothberg]

Sounds good to me, thanks @vbatts!

LGTM, @rhatdan PTAL

[rhatdan]

LGTM