containers / aardvark-dns

Authoritative dns server for A/AAAA container records. Forwards other request to host's /etc/resolv.conf
Apache License 2.0
176 stars 31 forks source link

fix reverse ipv6 lookup test flake #455

Closed Luap99 closed 4 months ago

Luap99 commented 4 months ago

The test assumed that we have a fdxx:... addresses which is what we should be getting normally, however the ipv6 subnet generator had a bug that caused it to create fdx:... sometimes which is different as ipv6 allows us to omit leading zeros, thus we actually have 0fdx which is not in the range we want to use at all.

So simply fix this by creating the proper subnet so that if the random number was less than 16 we add the leading zero add the proper place after fd.

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/aardvark-dns/blob/main/OWNERS)~~ [Luap99] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Luap99 commented 4 months ago

example failure https://api.cirrus-ci.com/v1/task/5119056867491840/logs/main.log, notice the f.0.ip6.arpa which is causing the regex to fail

Luap99 commented 4 months ago

@lsm5 Should we drop the RHEL 8 tasks? Repository 'epel-8-x86_64' does not exist in project 'rhcontainerbot/podman-next'.

Luap99 commented 4 months ago

@baude @mheon PTAL

mheon commented 4 months ago

/lgtm