search

containers / aardvark-dns

Authoritative dns server for A/AAAA container records. Forwards other request to host's /etc/resolv.conf
Apache License 2.0
176 stars 31 forks source link

[skip-ci] Packit: separate `packages` key for rhel jobs #459

Closed lsm5 closed 4 months ago

lsm5 commented 4 months ago

This should prevent status reporting issues as encountered in https://github.com/containers/aardvark-dns/pull/458 . The possible cause for the error was packit getting confused between two separate copr jobs with the same parameters but different targets.

Having a separate packages key for rhel jobs should make it easier for packit to do the right thing.

This should also make it possible for CentOS integration tests to run automatically on all PRs and not need manual triggering by a maintainer. Those were not triggered automatically on https://github.com/containers/aardvark-dns/pull/456 while the Fedora integration tests were.

packit-as-a-service[bot] commented 4 months ago

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {2: {'packages': defaultdict(<class 'dict'>, {'aardvark-dns-centos': {'value': {'idenfitifer': ['Unknown field.']}}})}}})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

packit-as-a-service[bot] commented 4 months ago

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {2: {'packages': defaultdict(<class 'dict'>, {'aardvark-dns-centos': {'value': {'idenfitifer': ['Unknown field.']}}})}}})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

packit-as-a-service[bot] commented 4 months ago

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {2: {'packages': defaultdict(<class 'dict'>, {'aardvark-dns-centos': {'value': {'idenfitifer': ['Unknown field.']}}})}}})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

lsm5 commented 4 months ago

there's some backlog in internal testing farm, the maintainers are aware of it.

packit-as-a-service[bot] commented 4 months ago

Integration tests failed. @containers/packit-build please check.

lsm5 commented 4 months ago

@Luap99 @mheon PTAL.

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/aardvark-dns/blob/main/OWNERS)~~ [Luap99,lsm5] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment