containers / aardvark-dns

Authoritative dns server for A/AAAA container records. Forwards other request to host's /etc/resolv.conf
Apache License 2.0
176 stars 31 forks source link

[skip-ci] RPM: use default __cargo macro across all envs #464

Closed lsm5 closed 3 months ago

lsm5 commented 3 months ago

On C9S and RHEL9, we've been specifying our own cargo macro which fails to create debuginfo packages with rust 1.77.2. Ref: https://blog.rust-lang.org/2024/03/21/Rust-1.77.0.html#enable-strip-in-release-profiles-by-default

This can be remedied by simply using the default __cargo macro provided on build environments.

packit-as-a-service[bot] commented 3 months ago

Ephemeral COPR build failed. @containers/packit-build please check.

lsm5 commented 3 months ago

Ignore ELN builds. Rawhide test failures are actually because of changes in dnf config-manager usage. I'll fix those in a followup. This PR should be good to go.

@Luap99 @mheon PTAL

mheon commented 3 months ago

LGTM

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/aardvark-dns/blob/main/OWNERS)~~ [Luap99,lsm5] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment