containers / aardvark-dns

Authoritative dns server for A/AAAA container records. Forwards other request to host's /etc/resolv.conf
Apache License 2.0
176 stars 31 forks source link

[skip-ci] TMT: Reorg and reuse upstream tests on downstream updates #465

Closed lsm5 closed 1 month ago

lsm5 commented 3 months ago

This commit accounts for breaking changes in dnf5 config-manager.

Merge after https://github.com/containers/aardvark-dns/pull/461

packit-as-a-service[bot] commented 3 months ago

Ephemeral COPR build failed. @containers/packit-build please check.

lsm5 commented 3 months ago

@mheon @Luap99 PTAL

packit-as-a-service[bot] commented 3 months ago

Integration tests failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 3 months ago

Ephemeral COPR build failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 3 months ago

Integration tests failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 3 months ago

Ephemeral COPR build failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 3 months ago

Integration tests failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 3 months ago

Ephemeral COPR build failed. @containers/packit-build please check.

lsm5 commented 3 months ago

I'll probably end up reworking this to also account for downstream reusability.

packit-as-a-service[bot] commented 3 months ago

Tests failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 3 months ago

Tests failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 3 months ago

Tests failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 2 months ago

Ephemeral COPR build failed. @containers/packit-build please check.

lsm5 commented 2 months ago

/packit build

lsm5 commented 2 months ago

/packit rebuild-failed

packit-as-a-service[bot] commented 2 months ago

Tests failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 2 months ago

Ephemeral COPR build failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 2 months ago

Tests failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 2 months ago

Ephemeral COPR build failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 2 months ago

Tests failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 2 months ago

Ephemeral COPR build failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 2 months ago

Tests failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 2 months ago

Ephemeral COPR build failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 2 months ago

Tests failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 2 months ago

Ephemeral COPR build failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 2 months ago

Tests failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 2 months ago

Ephemeral COPR build failed. @containers/packit-build please check.

lsm5 commented 2 months ago

@Luap99 @edsantiago @cevich PTAL at the current state. With this setup, we can reuse the tests for Fedora zuul (before dist-git PR merge) and bodhi updates and also on CentOS Stream.

See test downstream PR: https://src.fedoraproject.org/rpms/aardvark-dns/pull-request/20 and the actual TMT test trigger in Zuul: https://artifacts.dev.testing-farm.io/34dd8354-1a3d-4d34-ba58-9fb432581b8b/ .

Unit, validate and integration tests are run upstream while only the integration tests are run downstream.

Once everything looks ok, I'll re-enable failure notifications and repush for final merge.

lsm5 commented 1 month ago

PTAL again. Good for hopefully final review and merge. Thanks!

lsm5 commented 1 month ago

LGTM, I have no way to verify any of the downstream changes but looks like the upstream changes work and it is tested properly

Thanks @Luap99.

If anyone would like to verify how it looks like downstream (currently a manual sync), go to the dist-git test PR: https://src.fedoraproject.org/rpms/aardvark-dns/pull-request/20# -> Zuul CI result -> rpm-tmt-test -> Artifacts tab -> Testing Farm Artifacts. Only the downstream integration tests are run there.

The automatic syncing from Packit and bodhi results will only be found after an upstream release, unless we do a manual sync first. But Zuul results should be a strong enough indicator. HTH.

Luap99 commented 1 month ago

We cut a new release tomorrow should we get this merged for that?

lsm5 commented 1 month ago

We cut a new release tomorrow should we get this merged for that?

That would be great. Thanks @Luap99 . I have further simplifications lined up for container-selinux and netavark, which I can replicate in av as well for a followup.

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, lsm5, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/aardvark-dns/blob/main/OWNERS)~~ [Luap99,edsantiago,lsm5] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment