rework parts of coredns code

containers / aardvark-dns

Authoritative dns server for A/AAAA container records. Forwards other request to host's /etc/resolv.conf

Apache License 2.0

176 stars 31 forks source link

rework parts of coredns code #477

Closed Luap99 closed 1 month ago

Luap99 commented 1 month ago

Should make the code readable and also contains a bug fix. see commits

This is just a tiny part. I will restructure much more code on top of this but wanted to push in smaller steps for review.

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/aardvark-dns/blob/main/OWNERS)~~ [Luap99] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

mheon commented 1 month ago

Feels like a lot more than a 20 line removal, but I suppose the new function ate a lot of the margin. Oh well.

mheon commented 1 month ago

LGTM

mheon commented 1 month ago

/lgtm