rework parts of coredns and server code part 2

containers / aardvark-dns

Authoritative dns server for A/AAAA container records. Forwards other request to host's /etc/resolv.conf

Apache License 2.0

176 stars 31 forks source link

rework parts of coredns and server code part 2 #478

Closed Luap99 closed 1 month ago

Luap99 commented 1 month ago

This got a bit out of hand but I think the end result is much easier to understand and reason about.

see commits for details, it might be easier to just read the final coredns file for review rather than trying to make sense of the diff as a lot of code was moved around

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/aardvark-dns/blob/main/OWNERS)~~ [Luap99] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

mheon commented 1 month ago

/lgtm