search

containers / aardvark-dns

Authoritative dns server for A/AAAA container records. Forwards other request to host's /etc/resolv.conf
Apache License 2.0
176 stars 31 forks source link

More rework and cleanups to get closer to the place where we can report bind errors #483

Closed Luap99 closed 1 month ago

Luap99 commented 1 month ago

see commits

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/aardvark-dns/blob/main/OWNERS)~~ [Luap99] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
packit-as-a-service[bot] commented 1 month ago

We were not able to find or create Copr project packit/containers-aardvark-dns-483 specified in the config with the following error:

Cannot create a new Copr project (owner=packit project=containers-aardvark-dns-483 chroots=['centos-stream-9-x86_64', 'centos-stream-9-aarch64', 'centos-stream-10-aarch64', 'centos-stream-10-x86_64']): Copr: 'packit/containers-aardvark-dns-483' already exists. Copr HTTP response is 400 BAD REQUEST.

Unless the HTTP status code above is >= 500, please check your configuration for:

  1. typos in owner and project name (groups need to be prefixed with @)
  2. whether the project name doesn't contain not allowed characters (only letters, digits, underscores, dashes and dots must be used)
  3. whether the project itself exists (Packit creates projects only in its own namespace)
  4. whether Packit is allowed to build in your Copr project
  5. whether your Copr project/group is not private
Luap99 commented 1 month ago

@mheon PTAL This doesn't yet include the error handling we talked about because it seems it doesn't quite work the way I hopped. I likely need to roll our own multi error type for it.

mheon commented 1 month ago

/lgtm