containers / aardvark-dns

Authoritative dns server for A/AAAA container records. Forwards other request to host's /etc/resolv.conf
Apache License 2.0
176 stars 31 forks source link

add tcp support #484

Closed Luap99 closed 1 month ago

Luap99 commented 1 month ago

see commits

Listen and forward via tcp as well not just udp

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/aardvark-dns/blob/main/OWNERS)~~ [Luap99] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
packit-as-a-service[bot] commented 1 month ago

Unit tests failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 1 month ago

Unit tests failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 1 month ago

Unit tests failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 1 month ago

Integration tests failed. @containers/packit-build please check.

Luap99 commented 1 month ago

looks like the bind with ncat test is flaky (I need to add some sleep there even if that sucks)

Luap99 commented 1 month ago

Ok pushed another commits to do tcp forwarding as well

mheon commented 1 month ago

/lgtm

TomSweeneyRedHat commented 1 month ago

Addresses: https://issues.redhat.com/browse/RHEL-17270