search

containers / aardvark-dns

Authoritative dns server for A/AAAA container records. Forwards other request to host's /etc/resolv.conf
Apache License 2.0
176 stars 31 forks source link

[skip-ci] Packit/TMT: simplify tests #491

Open lsm5 opened 1 month ago

lsm5 commented 1 month ago

Use idiomatic packit to configure podman-next copr repos for upstream tests and simplify test script.

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/aardvark-dns/blob/main/OWNERS)~~ [lsm5] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
packit-as-a-service[bot] commented 1 month ago

Tests failed. @containers/packit-build please check.

lsm5 commented 1 month ago

test 5 is run on rhel-9 and c9s in this run, but being skipped on c10s.

lsm5 commented 1 month ago

@Luap99 @edsantiago any idea about the rhel9 / c9s failures?

Luap99 commented 1 month ago

@Luap99 @edsantiago any idea about the rhel9 / c9s failures?

# #/vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
# #|     FAIL: server used TCP
# #| expected: =~ '\(TCP\)'
# #|   actual:    '; <<>> DiG 9.16.23-RH <<>> +tcp google.com @10.45.253.1'
# #|         >    ';; global options: +cmd'
# #|         >    ';; Got answer:'
# #|         >    ';; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 56432'
# #|         >    ';; flags: qr rd ra; QUERY: 1, ANSWER: 1, AUTHORITY: 0, ADDITIONAL: 1'
# #|         >    ';; OPT PSEUDOSECTION:'
# #|         >    '; EDNS: version: 0, flags:; udp: 4096'
# #|         >    ';; QUESTION SECTION:'
# #|         >    ';google.com.         IN  A'
# #|         >    ';; ANSWER SECTION:'
# #|         >    'google.com.      179 IN  A   172.217.2.46'
# #|         >    ';; Query time: 9 msec'
# #|         >    ';; SERVER: 10.45.253.1#53(10.45.253.1)'
# #|         >    ';; WHEN: Fri Aug 02 16:18:11 UTC 2024'
# #|         >    ';; MSG SIZE  rcvd: 55'
# #\^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

the dig version doesn't output TCP in the output so the test has no way to guarantee that we actually used tcp other than the +tcp arg (which well may be good enough), on newer versions the SERVER lines contains either (TCP) or (UDP)

I like to keep the TCP output check if possible because it is easy remove the +tcp argument by accident but I don't see a good way to work around that either other than removing this check

edsantiago commented 1 month ago

The (TCP|UDP) output seems to be very new, in bind 9.18 or so (it is not in bind 9.16). I'm guessing that RHEL9 has too old a version of bind-utils. @Luap99 perhaps a better safeguard might be

    assert "$output" !~ "SERVER.*UDP"