containers / aardvark-dns

Authoritative dns server for A/AAAA container records. Forwards other request to host's /etc/resolv.conf
Apache License 2.0
186 stars 32 forks source link

netavark_cache_groom.sh: fix wrong branch #510

Closed Luap99 closed 1 month ago

Luap99 commented 1 month ago

As this download from the netavark repo is should use the NETAVARK_BRANCH env.

Porting from https://github.com/containers/aardvark-dns/pull/507, not failing on main as both branches are set to main here anyway but in case we have a async branch setup in the future again we need this

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/aardvark-dns/blob/main/OWNERS)~~ [Luap99] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
packit-as-a-service[bot] commented 1 month ago

Tests failed. @containers/packit-build please check.

Luap99 commented 1 month ago

@mheon @baude PTAL

mheon commented 1 month ago

LGTM

baude commented 1 month ago

/lgtm