search

containers / ai-lab-recipes

Examples for building and running LLM services and applications locally with Podman
Apache License 2.0
111 stars 110 forks source link

RHELAI-473: Adding rhel ai version #665

Closed tsorya closed 4 months ago

tsorya commented 4 months ago

Adding rhel ai version Set github hash by defautl as image version. Add RHEL AI as variant into /etc/os-release in order to use it in insights

NAME="Red Hat Enterprise Linux" VERSION="9.20240630.0.4 (Plow)" ID="rhel" ID_LIKE="fedora" VERSION_ID="9.4" PLATFORM_ID="platform:el9" PRETTY_NAME="Red Hat Enterprise Linux 9.20240630.0.4 (Plow)" ANSI_COLOR="0;31" LOGO="fedora-logo-icon" CPE_NAME="cpe:/o:redhat:enterprise_linux:9::baseos" HOME_URL="https://www.redhat.com/" DOCUMENTATION_URL="https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/9" BUG_REPORT_URL="https://bugzilla.redhat.com/" REDHAT_BUGZILLA_PRODUCT="Red Hat Enterprise Linux 9" REDHAT_BUGZILLA_PRODUCT_VERSION=9.4 REDHAT_SUPPORT_PRODUCT="Red Hat Enterprise Linux" REDHAT_SUPPORT_PRODUCT_VERSION="9.4" OSTREE_VERSION='9.20240630.0' VARIANT_ID=rhel_ai1 VARIANT="RHEL AI" BUILD_ID='v1.1.3'

Gregory-Pereira commented 4 months ago

This strikes me as a change we should add downstream as a new containerfile or a patch rather than here in the upstream, but not entirely sure. cc @fabiendupont @lmilbaum

Gregory-Pereira commented 4 months ago

This strikes me as a change we should add downstream as a new containerfile or a patch rather than here in the upstream, but not entirely sure. cc @fabiendupont @lmilbaum

Just found your comment in slack, the above is resolved by this but going to post it here for posterity:

We should set real version in downstream build, just wanted to have some default

fabiendupont commented 4 months ago

The OS can be something else than RHEL, so not sure that RHEL in the variable name is relevant. /cc @romfreiman @n1hility

tsorya commented 4 months ago

@fabiendupont do we have some more generic name for it? I mean i can change to make it ${OS_ID}_AI_VERSION or just something hardcoded that will match better, just don't know what.

tsorya commented 4 months ago

@Gregory-Pereira i think setting git hash in upstream or provide the way for dev to setup their own versioning can be helpful too and in downstream we will set release versions

rhatdan commented 4 months ago

I agree this should be done downstream, not upstream.

tsorya commented 4 months ago

I agree this should be done downstream, not upstream.

Currently downstream uses upstream containerfile. I added verification that it is rhel image in order to set this field only for rhel

tsorya commented 4 months ago

/hold till we will decide which exact var we should change in /etc/os-release

tsorya commented 4 months ago

/hold

tsorya commented 4 months ago

/unhold Seems like we have decision

lmilbaum commented 4 months ago

Joining late to the party. What does this variable used for? If we agree that it is needed, should it be populated via a builds arg file?