containers / ai-lab-recipes

Examples for building and running LLM services and applications locally with Podman
Apache License 2.0
103 stars 106 forks source link

nvidia-bootc: Duplicate common lib & ilab, to avoid an intermediate makefile target #696

Closed pastequo closed 2 months ago

pastequo commented 2 months ago

Following a discussion with @ralphbean , it would be preferable to avoid any makefile command before building this image in Konflux.

This PR dupplicates the required files

romfreiman commented 2 months ago

@rhatdan ptal

romfreiman commented 2 months ago

/hold what are the minimum required changes to add the upgrade notification service?

pastequo commented 2 months ago

@romfreiman New version, dupplicating lib & ilab

/cc @kwozyman @javipolo

javipolo commented 2 months ago

LGTM

Gregory-Pereira commented 2 months ago

Can we fix DCO?