containers / ai-lab-recipes

Examples for building and running LLM services and applications locally with Podman
Apache License 2.0
103 stars 106 forks source link

Require KERNEL_VERSION argument in driver-toolkit #718

Closed fabiendupont closed 1 month ago

fabiendupont commented 1 month ago

The default base image for the Driver Toolkit image is centos:stream9. The original work for Driver Toolkit is in OpenShift and the base image is ubi9/ubi. In bother cases, the images don't have the kernel package installed.

This change adds a test on the KERNEL_VERSION argument and exits if it's not provided at build time. This also ensure that only the relevant kernel is present when using centos:stream9 or ubi9/ubi as the base image. And this realigns a bit with the original Driver Toolkit.

rhatdan commented 1 month ago

LGTM