containers / ai-lab-recipes

Examples for building and running LLM services and applications locally with Podman
Apache License 2.0
103 stars 106 forks source link

Remove retagging from ilab image #757

Closed enriquebelarte closed 1 month ago

enriquebelarte commented 1 month ago

Retag is not needed as we are using static tags now.

lmilbaum commented 1 month ago

@pastequo Please review the changes before it is merged

rhatdan commented 1 month ago

Are you sure the image in the additional store ends up labeled correctly?

pastequo commented 1 month ago

The retag was instaured because without it "podman images" or equivalent was displaying <none>

enriquebelarte commented 1 month ago

@pastequo If I'm not mistaken the retag was needed because digest tags made the podman images output show tag field as <none> . We're not using digest tags now but static ones that's why my guess is that the code is not needed anymore.

rhatdan commented 1 month ago

LGTM