containers / ansible-podman-collections

Repository for Ansible content that can include playbooks, roles, modules, and plugins for use with the Podman tool
GNU General Public License v3.0
270 stars 148 forks source link

Quadlet example in documentation uses unsupported pull policy #861

Closed InsideTheVoid closed 3 weeks ago

InsideTheVoid commented 4 weeks ago

The quadlet example on Ansible Community Documentation uses Pull=true which is not supported.

- name: Create a Quadlet file
  containers.podman.podman_container:
    name: quadlet-container
    image: nginx
    state: quadlet
    quadlet_filename: custome-container
    device: "/dev/sda:/dev/xvda:rwm"
    ports:
      - "8080:80"
    volumes:
      - "/var/www:/usr/share/nginx/html"
    quadlet_options:
      - "AutoUpdate=registry"
      - "Pull=true"
      - |
        [Install]
        WantedBy=default.target

Podman reports Error: unsupported pull policy "true".

The example should be changed to one of these choices:

sshnaidm commented 4 weeks ago

@InsideTheVoid would you like to submit a patch?

InsideTheVoid commented 3 weeks ago

@sshnaidm Could you please let me know if everything looks as it should?

sshnaidm commented 3 weeks ago

@InsideTheVoid yeah, totally fine. Please sign a commit with git commit --amend -s and feel free to make a PR to this repo.