search

containers / bootc

Boot and upgrade via container images
https://containers.github.io/bootc/
Apache License 2.0
789 stars 84 forks source link

Status tweaks #798

Closed cgwalters closed 2 months ago

cgwalters commented 2 months ago

status: Change transport display

Registry is the assumed default; let's be quieter (less output) in this default/expected case.

If we're using something else (e.g. oci) then put it inline with the image name as that's something one can pass to e.g. skopeo.

Signed-off-by: Colin Walters walters@verbum.org

status: Minor code refactorings

Signed-off-by: Colin Walters walters@verbum.org

status: Factor out helpers for rendering container image

Prep for more work; no functional changes.

Signed-off-by: Colin Walters walters@verbum.org

djach7 commented 2 months ago

Just tried to test this locally for a bit and kept running into this error:

ERROR Status: Computing status: Booted deployment: Reading deployment metadata: Missing base image ref ostree/container/blob/d5f71a3300fe94bed5ec6cbf5a6e508a0da96d48057ba76d80a8426add6ef9ee

Any ideas what's causing that? I don't think I'm setting up the bootc environment wrong, as other commands (like bootc help and bootc --version) work fine

cgwalters commented 2 months ago

see https://github.com/containers/bootc/issues/800

djach7 commented 2 months ago

Ah, I see. I'll review as much as I can then without being able to test the full thing. My apologies for not staying more on top of my github notifications

cgwalters commented 2 months ago

800 only bites for the upgrade case, which is how it sailed through our primary CI. If you create a fresh image with current bootc git it will work. So e.g. podman-bootc run <image> etc.