search

containers / bootc

Boot and upgrade via container images
https://containers.github.io/bootc/
Apache License 2.0
789 stars 84 forks source link

deploy: Add a spinner #848

Closed cgwalters closed 3 weeks ago

cgwalters commented 1 month ago

deploy: Use bar.println

In some cases I wasn't seeing this output, and I think it's because we hadn't drop()'d the bar. Since it's in scope it's cleaner to use its println method.

Signed-off-by: Colin Walters walters@verbum.org

deploy: Add a spinner

First, this operation was absolutely not asynchronous and we need to spawn it in a helper thread on general principle. Doing that is unfortunately VERY hacky because we need to clone a lot of things and especially there's an ergonomics hit here since Deployment is incorrectly !Send.

But the main motivation is this operation can be slow sometimes, so let's show progress output so the admin knows we're not blocked.

Closes: https://github.com/containers/bootc/issues/842 Signed-off-by: Colin Walters walters@verbum.org

utils: Print and log time for async_task_with_spinner

Things we do via this mechanism can take some time; let's log the elapsed time for greater visibility both to the human output and log to the journal.

Signed-off-by: Colin Walters walters@verbum.org

omertuc commented 3 weeks ago

/lgtm

omertuc commented 3 weeks ago

Oh and FYI, IDK if you care but you added tracing::debug!("Deploying commit {ostree_commit}"); under a seemingly irrelevant commit (adc37abfaac47dad094b2b902e904adda0d42946)

cgwalters commented 3 weeks ago

Oh and FYI, IDK if you care but you added tracing::debug!("Deploying commit {ostree_commit}"); under a seemingly irrelevant commit (https://github.com/containers/bootc/commit/adc37abfaac47dad094b2b902e904adda0d42946)

I dropped that

cgwalters commented 3 weeks ago

/lgtm

This repository doesn't use Prow, so to merge it needs a Github approval state