install: Add hidden `ensure-completion` verb

containers / bootc

Boot and upgrade via container images

https://containers.github.io/bootc/

Apache License 2.0

769 stars 83 forks source link

Open cgwalters opened 2 days ago

cgwalters commented 2 days ago

This will be runnable via

%post --erroronfail
bootc install ensure-completion
%end

in Anaconda to work around the fact that it's not today using bootc install to-filesystem.

cgwalters commented 2 days ago

This seems to be working well in my hand-rolled testing. (BTW I am testing via https://github.com/virt-manager/virt-manager/issues/739#issuecomment-2489529672 )

Still TODO:

[x] Add LBI pulling
[ ] Add tests
[ ] Also try to re-do the ostree deployment to handle fixups like this one or this one ?

cgwalters commented 9 hours ago

OK I've rebased this on top of https://github.com/containers/bootc/pull/860 and we successfully pull LBIs at Anaconda install time too now.

cgwalters commented 9 hours ago

There were a surprising number of things I hit. One of them for example is that anaconda's hand-rolled chroot/container doesn't mount cgroupfs which makes podman quite unhappy so we do so manually in https://github.com/containers/bootc/pull/915/files#diff-66bc72c28514e2546fbe456aee74a321866d5a9147136ef99251eec1e08be8ddR107