search

containers / bubblewrap

Low-level unprivileged sandboxing tool used by Flatpak and similar projects
Other
3.9k stars 238 forks source link

tests: use stat -c instead of --format for compatibility #627

Closed sertonix closed 1 day ago

sertonix commented 5 months ago

eg. busybox stat only has -c and not --format

sertonix commented 5 months ago

Ok, done

smcv commented 5 months ago

@alexlarsson, @cgwalters: Please confirm whether you are intending to enforce the rule that Signed-off-by must be from (something that looks like) a real name, and not from an obvious pseudonym?

This PR and #618 are both blocked by having a decision on that. I would personally be fine with a pseudonymous Signed-off-by, especially for small contributions - but I didn't write the rule, so I don't feel that I can be the one to change it.

smcv commented 1 day ago

@alexlarsson, @cgwalters: Please confirm whether you are intending to enforce the rule that Signed-off-by must be from (something that looks like) a real name, and not from an obvious pseudonym?

This PR and #618 are both blocked by having a decision on that.

Right, enough is enough: I've waited too long for a decision on whether this and several other simple fixes can be landed, and it's not like we can tell whether any given contribution is Signed-off-by someone's legal name or a plausible pseudonym anyway, so I'm going to say the answer is "yes" and start merging pseudonymous contributions.

@alexlarsson, @cgwalters, if this is a problem, please revert the relevant changes (and then get equivalent fixes some other way).

smcv commented 1 day ago

so I'm going to say the answer is "yes" and start merging pseudonymous contributions

(Except not right now, because unrelatedly the Github Actions configuration has regressed, so if anyone has objections to this, you have until the Actions are fixed to raise your objection.)

cgwalters commented 1 day ago

It looks like the most canonical docs for this are https://github.com/cncf/foundation/blob/main/dco-guidelines.md

I believe the signoff line here qualifies.

sertonix commented 7 hours ago

so I'm going to say the answer is "yes" and start merging pseudonymous contributions

Thank you!