containers / bubblewrap

Low-level unprivileged sandboxing tool used by Flatpak and similar projects
Other
3.97k stars 237 forks source link

Add new --level-prefix option #646

Closed smcv closed 1 month ago

smcv commented 4 months ago

cc @refi64 @RyuzakiKK

smcv commented 3 months ago

Updated: while reviewing a similar change in libcapsule, @refi64 pointed out that I'd described the prefixes as "syslog-style" here, but not in libcapsule. In fact saying "syslog-style" is misleading, because https://datatracker.ietf.org/doc/html/rfc5424#section-6.2 describes a prefix that encodes both the severity and the facility, whereas here we're using only the severity, in order to be compatible with systemd-cat(1). Consistently say "severity" in preference to "priority" to reflect this.

(Documentation updates only; the only code change is to rename a level function parameter to severity.)

smcv commented 3 months ago

Any thoughts on this from other maintainers? My colleague @refi64 already provided some useful feedback, which I've addressed.

RyuzakiKK commented 3 months ago

I'm not a maintainer, but FWIW this looks good to me as well.