containers / bubblewrap

Low-level unprivileged sandboxing tool used by Flatpak and similar projects
Other
3.97k stars 237 forks source link

utils: Avoid shadowing the names of global functions #661

Closed smcv closed 1 month ago

smcv commented 1 month ago

dirfd() and socket() are POSIX standard library functions, so use dfd and sockfd instead.


This fixes build failures with gcc 4.6 in an Ubuntu 12.04 derivative, but seems like a good cleanup change to make the code easier to understand, even if gcc no longer warns about this particular collision.

Unfortunately this is going to conflict with #659, although the conflict resolution is simple and obvious.

cc @refi64

swick commented 1 month ago

LGTM