search

containers / bubblewrap

Low-level unprivileged sandboxing tool used by Flatpak and similar projects
Other
3.99k stars 239 forks source link

completions: Don't try to define more than one variable for pkg-config #664

Closed smcv closed 4 weeks ago

smcv commented 1 month ago

Before Meson 1.3.0, this would not do what we meant (instead defining prefix to a wrong value composed from the remaining arguments).

The only reason we needed to redefine prefix in the first place is that bash-completion older than 2.10 did not allow users of its pkg-config file to override the datadir used to compute its completionsdir, but that was addressed in version 2.10 (2019). Users of older bash-completion should set bubblewrap's bash_completion_dir build option, if the automatically-discovered default is not appropriate.

Related to https://github.com/containers/bubblewrap/issues/609

/cc @refi64 @eli-schwartz

smcv commented 4 weeks ago

Please could someone review this? Ideally a maintainer (in theory I have co-maintainers...) but failing that, perhaps a non-maintainer could take a look?

cc @RyuzakiKK