search

containers / build

another build tool for container images (archived, see https://github.com/rkt/rkt/issues/4024)
Apache License 2.0
342 stars 80 forks source link

godep: bump the version of rkt to v1.2.0 #193

Closed cgonyeo closed 8 years ago

cgonyeo commented 8 years ago

Until a consensus is reached on moving to glide, I'd like to bump the appc version (which required bumping the rkt version) used by acbuild. This allows for apps with an empty exec statement.

jonboulle commented 8 years ago

Build broke

cgonyeo commented 8 years ago

Fixed the build. Apparently I need godep go build now instead of go build.

jonboulle commented 8 years ago

Eurgh. Instead, set GOPATH: https://github.com/appc/spec/pull/578/files#diff-b0da275520918e23dd615e2a747528f1L13

jonboulle commented 8 years ago

Also if you're going to unrewrite paths too (which I think is probably a good idea at this stage), please add something to the commit message to that effect (or split it into two commits)

cgonyeo commented 8 years ago

Tweaked the commit message, and decided to mess with the build/test scripts while I'm here.

jonboulle commented 8 years ago

Can't actually review the important changes, thanks github :-(

cgonyeo commented 8 years ago

The big change in the build/test scripts is this: https://github.com/appc/acbuild/blob/1beb799d4e93c4ee9860156e03405cf7b2c49357/build#L6

jonboulle commented 8 years ago

if it works, ship it