search

containers / build

another build tool for container images (archived, see https://github.com/rkt/rkt/issues/4024)
Apache License 2.0
342 stars 80 forks source link

Provide Image ID on "write" #305

Closed trusch closed 7 years ago

trusch commented 7 years ago

It would be nice to have acbuild output the image ID of the generated image. If not, you need to uncompress and hash the tarball contents by hand.

related to https://github.com/rkt/rkt/issues/3667

I would try to take care about this, PR will follow this week.

lucab commented 7 years ago

@dgonyeo any preferences on whether this should be part of end or write? Also, should this be opt-in or opt-out?

cgonyeo commented 7 years ago

It should definitely be part of write, as end will also be called in the event of build failures. I'm indifferent to it being opt-in or opt-out.

lucab commented 7 years ago

Fixed via https://github.com/containers/build/pull/306.