Improve shell script - Githubissues

containers / build

another build tool for container images (archived, see https://github.com/rkt/rkt/issues/4024)

Apache License 2.0

342 stars 80 forks source link

Improve shell script #320

Closed sanmai-NL closed 7 years ago

sanmai-NL commented 7 years ago

Use a POSIX-compatible shell script and remove references to Bash.
More complete handling of corner cases (e.g. failing acbuild end, termination signal, etc.)
Mark tutorial-style info as extra background section.

cgonyeo commented 7 years ago

What's the motivation against using bash? It should be widely available, and has more features for users when writing scripts.

sanmai-NL commented 7 years ago

Bash is not available by default under e.g. Alpine Linux. The sample code does not require Bash in any way. Bash has had CVEs, more than e.g. dash. Bash may be nice for interactive shells, for shell scripting a portable script is better.