search

containers / buildah

A tool that facilitates building OCI images.
https://buildah.io
Apache License 2.0
7.24k stars 766 forks source link

buildah manifest inspect returns different results than podman manifest inspect #2494

Closed buckaroogeek closed 4 years ago

buckaroogeek commented 4 years ago

Description

I am experimenting with using buildah to create multiarch images (using code shared by @nalind on youtube). With a multiarch manifest in a local repository, I would expect 

podman manifest inspect 8e80b676c19d

to be identical to 

buildah manifest inspect 8e80b676c19d

Steps to reproduce the issue:

  1. buildah manifest inspect 8e80b676c19d (for example)
  2. podman manifest inspect 8e80b676c19d (same image)
  3. compare result (please see below)

Describe the results you received:

[bgsmith@pico src]$ podman images
REPOSITORY                         TAG     IMAGE ID      CREATED      SIZE
localhost/buckaroogeek/doh-client  latest  8e80b676c19d  2 days ago   1.16 kB
localhost/doh-client               2.2.8   8e80b676c19d  2 days ago   1.16 kB

(repo list truncated)

[bgsmith@pico src]$ buildah manifest inspect 8e80b676c19d
error resolving image names: error locating images with names [8e80b676c19d8694a489c3fa71fde3c05e94644e84ea0bc95edbbea5174007e4]
ERRO exit status 125                              
[bgsmith@pico src]$ podman manifest inspect 8e80b676c19d
{
    "schemaVersion": 2,
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "manifests": [
        {
            "mediaType": "application/vnd.oci.image.manifest.v1+json",
            "size": 497,
            "digest": "sha256:0c8c4d30a2050a88a39f281797405e389d5ce453ef4f4b9d7534e34fbd3045f5",
            "platform": {
                "architecture": "arm64",
                "os": "linux",
                "variant": "v8"
            }
        },
        {
            "mediaType": "application/vnd.oci.image.manifest.v1+json",
            "size": 497,
            "digest": "sha256:22345e4a24cd86b03129feb26996d5663589f8b34eac251276f390a6908f9717",
            "platform": {
                "architecture": "amd64",
                "os": "linux"
            }
        }
    ]
}

Describe the results you expected: Identical result for manifest inspect on an image.

Output of rpm -q buildah or apt list buildah:

buildah-1.15.0-1.fc32.x86_64

Output of buildah version:

[bgsmith@pico src]$ buildah version
Version:         1.15.0
Go Version:      go1.14.3
Image Spec:      1.0.1-dev
Runtime Spec:    1.0.2-dev
CNI Spec:        0.4.0
libcni Version:  
image Version:   5.5.1
Git Commit:      
Built:           Wed Dec 31 16:00:00 1969
OS/Arch:         linux/amd64

Output of podman version if reporting a podman build issue:

[bgsmith@pico src]$ podman version
Version:      2.0.3
API Version:  1
Go Version:   go1.14.3
Built:        Wed Dec 31 16:00:00 1969
OS/Arch:      linux/amd64

*Output of `cat /etc/release`:**

[bgsmith@pico src]$ cat /etc/*release
Fedora release 32 (Thirty Two)
NAME=Fedora
VERSION="32 (Workstation Edition)"
ID=fedora
VERSION_ID=32
VERSION_CODENAME=""
PLATFORM_ID="platform:f32"
PRETTY_NAME="Fedora 32 (Workstation Edition)"
ANSI_COLOR="0;34"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:32"
HOME_URL="https://fedoraproject.org/"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/f32/system-administrators-guide/"
SUPPORT_URL="https://fedoraproject.org/wiki/Communicating_and_getting_help"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=32
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=32
PRIVACY_POLICY_URL="https://fedoraproject.org/wiki/Legal:PrivacyPolicy"
VARIANT="Workstation Edition"
VARIANT_ID=workstation
Fedora release 32 (Thirty Two)
Fedora release 32 (Thirty Two)

Output of uname -a:

Linux pico 5.7.10-201.fc32.x86_64 #1 SMP Thu Jul 23 00:58:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Output of cat /etc/containers/storage.conf:

[bgsmith@pico src]$ cat /etc/containers/storage.conf
# This file is is the configuration file for all tools
# that use the containers/storage library.
# See man 5 containers-storage.conf for more information
# The "container storage" table contains all of the server options.
[storage]

# Default Storage Driver
driver = "overlay"

# Temporary storage location
runroot = "/var/run/containers/storage"

# Primary Read/Write location of container storage
graphroot = "/var/lib/containers/storage"

# Storage path for rootless users
#
# rootless_storage_path = "$HOME/.local/share/containers/storage"

[storage.options]
# Storage options to be passed to underlying storage drivers

# AdditionalImageStores is used to pass paths to additional Read/Only image stores
# Must be comma separated list.
additionalimagestores = [
]

# Remap-UIDs/GIDs is the mapping from UIDs/GIDs as they should appear inside of
# a container, to the UIDs/GIDs as they should appear outside of the container,
# and the length of the range of UIDs/GIDs.  Additional mapped sets can be
# listed and will be heeded by libraries, but there are limits to the number of
# mappings which the kernel will allow when you later attempt to run a
# container.
#
# remap-uids = 0:1668442479:65536
# remap-gids = 0:1668442479:65536

# Remap-User/Group is a user name which can be used to look up one or more UID/GID
# ranges in the /etc/subuid or /etc/subgid file.  Mappings are set up starting
# with an in-container ID of 0 and then a host-level ID taken from the lowest
# range that matches the specified name, and using the length of that range.
# Additional ranges are then assigned, using the ranges which specify the
# lowest host-level IDs first, to the lowest not-yet-mapped in-container ID,
# until all of the entries have been used for maps.
#
# remap-user = "containers"
# remap-group = "containers"

# Root-auto-userns-user is a user name which can be used to look up one or more UID/GID
# ranges in the /etc/subuid and /etc/subgid file.  These ranges will be partioned
# to containers configured to create automatically a user namespace.  Containers
# configured to automatically create a user namespace can still overlap with containers
# having an explicit mapping set.
# This setting is ignored when running as rootless.
# root-auto-userns-user = "storage"
#
# Auto-userns-min-size is the minimum size for a user namespace created automatically.
# auto-userns-min-size=1024
#
# Auto-userns-max-size is the minimum size for a user namespace created automatically.
# auto-userns-max-size=65536

[storage.options.overlay]
# ignore_chown_errors can be set to allow a non privileged user running with
# a single UID within a user namespace to run containers. The user can pull
# and use any image even those with multiple uids.  Note multiple UIDs will be
# squashed down to the default uid in the container.  These images will have no
# separation between the users in the container. Only supported for the overlay
# and vfs drivers.
#ignore_chown_errors = false

# Path to an helper program to use for mounting the file system instead of mounting it
# directly.
#mount_program = "/usr/bin/fuse-overlayfs"

# mountopt specifies comma separated list of extra mount options
mountopt = "nodev,metacopy=on"

# Size is used to set a maximum size of the container image.
# size = ""

[storage.options.thinpool]
# Storage Options for thinpool

# autoextend_percent determines the amount by which pool needs to be
# grown. This is specified in terms of % of pool size. So a value of 20 means
# that when threshold is hit, pool will be grown by 20% of existing
# pool size.
# autoextend_percent = "20"

# autoextend_threshold determines the pool extension threshold in terms
# of percentage of pool size. For example, if threshold is 60, that means when
# pool is 60% full, threshold has been hit.
# autoextend_threshold = "80"

# basesize specifies the size to use when creating the base device, which
# limits the size of images and containers.
# basesize = "10G"

# blocksize specifies a custom blocksize to use for the thin pool.
# blocksize="64k"

# directlvm_device specifies a custom block storage device to use for the
# thin pool. Required if you setup devicemapper.
# directlvm_device = ""

# directlvm_device_force wipes device even if device already has a filesystem.
# directlvm_device_force = "True"

# fs specifies the filesystem type to use for the base device.
# fs="xfs"

# log_level sets the log level of devicemapper.
# 0: LogLevelSuppress 0 (Default)
# 2: LogLevelFatal
# 3: LogLevelErr
# 4: LogLevelWarn
# 5: LogLevelNotice
# 6: LogLevelInfo
# 7: LogLevelDebug
# log_level = "7"

# min_free_space specifies the min free space percent in a thin pool require for
# new device creation to succeed. Valid values are from 0% - 99%.
# Value 0% disables
# min_free_space = "10%"

# mkfsarg specifies extra mkfs arguments to be used when creating the base
# device.
# mkfsarg = ""

# Size is used to set a maximum size of the container image.
# size = ""

# use_deferred_removal marks devicemapper block device for deferred removal.
# If the thinpool is in use when the driver attempts to remove it, the driver
# tells the kernel to remove it as soon as possible. Note this does not free
# up the disk space, use deferred deletion to fully remove the thinpool.
# use_deferred_removal = "True"

# use_deferred_deletion marks thinpool device for deferred deletion.
# If the device is busy when the driver attempts to delete it, the driver
# will attempt to delete device every 30 seconds until successful.
# If the program using the driver exits, the driver will continue attempting
# to cleanup the next time the driver is used. Deferred deletion permanently
# deletes the device and all data stored in device will be lost.
# use_deferred_deletion = "True"

# xfs_nospace_max_retries specifies the maximum number of retries XFS should
# attempt to complete IO when ENOSPC (no space) error is returned by
# underlying storage device.
# xfs_nospace_max_retries = "0"
rhatdan commented 4 years ago

@QiWang19 PTAL

QiWang19 commented 4 years ago

Are you expecting podman manifest returning the error resolving image names like buildah because the images have same IDs? Is this is a podman issue?

If this is a buildah issue, I avoid the error by manifest inspect the image name instead of using the id. But buildah should support resolving the id.

buckaroogeek commented 4 years ago

@QiWang19 - I would expect both podman and buildah to return the same result. And my preference would be for the podman result (ie display the manifest). Repositories will likely have the same image ID on multiple images if tags are used. Tag 'latest' is identical since the most recent version of the container is 2.2.8. Parenthetically I am going to drop 'latest' but there may well be use cases for multiple images sharing the same image ID.

thanks!

buckaroogeek commented 4 years ago

@QiWang19 - based on a couple of experiments, I would offer that 'buildah manifest inspect' is more strict than 'podman manifest inspect'. For example (using the repo list in the original post)

[bgsmith@pico dns-over-https]$ podman manifest inspect doh-client
{
    "schemaVersion": 2,
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "manifests": [
        {
            "mediaType": "application/vnd.oci.image.manifest.v1+json",
            "size": 497,
            "digest": "sha256:0c8c4d30a2050a88a39f281797405e389d5ce453ef4f4b9d7534e34fbd3045f5",
            "platform": {
                "architecture": "arm64",
                "os": "linux",
                "variant": "v8"
            }
        },
        {
            "mediaType": "application/vnd.oci.image.manifest.v1+json",
            "size": 497,
            "digest": "sha256:22345e4a24cd86b03129feb26996d5663589f8b34eac251276f390a6908f9717",
            "platform": {
                "architecture": "amd64",
                "os": "linux"
            }
        }
    ]
}
[bgsmith@pico dns-over-https]$ buildah manifest inspect doh-client
tried reading image "docker://doh-client:latest": Error reading manifest latest in docker.io/library/doh-client: errors:
denied: requested access to the resource is denied
unauthorized: authentication required

: tried reading image "docker://registry.centos.org/doh-client:latest": Error reading manifest latest in registry.centos.org/doh-client: manifest unknown: manifest unknown
: tried reading image "docker://registry.access.redhat.com/doh-client:latest": Error reading manifest latest in registry.access.redhat.com/doh-client: name unknown: Repo not found
: tried reading image "docker://registry.fedoraproject.org/doh-client:latest": Error reading manifest latest in registry.fedoraproject.org/doh-client: manifest unknown: manifest unknown
: reading image "docker://localhost/doh-client:latest": error pinging docker registry localhost: Get "https://localhost/v2/": dial tcp [::1]:443: connect: connection refused
ERRO exit status 125

but I get the manifest if I do

buildah manifest inspect doh-client:2.2.8

Would it be better for both buildah and podman to work the same way when doing a manifest inspect? I.E consist behavior from both buildah and podman. I lean to the 'be liberal in what you accept' but consistency would have value.

thanks!