containers / buildah

A tool that facilitates building OCI images.
https://buildah.io
Apache License 2.0
7.16k stars 766 forks source link

Cannot build image using Buildah:1.20.0 (rootless) #3120

Closed qtekk closed 3 years ago

qtekk commented 3 years ago

Description

After Buildah's update to 1.20.0, I'm no longer able to create a new image as a non-root user. It was possible on a previous version that I had.

Steps to reproduce the issue:

  1. CONTAINER=$(buildah from adoptopenjdk/openjdk11:alpine-slim)
  2. buildah commit $CONTAINER test

Describe the results you received:

ERRO error unmounting /home/lkuta/.local/share/containers/storage/overlay/cbb0b23158e8e9a782423ca63117dc09cf80da6e42af304dd817d625e2f53aa2/merged: invalid argument 
error committing container "openjdk11-working-container-3" to "test": error copying layers and metadata for container "ed3f2edb983e146b5ec51267bafca17625dbce0368d27f954784ef5429b3d386": Error initializing source containers-storage:openjdk11-working-container-3: error extracting layer "cbb0b23158e8e9a782423ca63117dc09cf80da6e42af304dd817d625e2f53aa2": error creating overlay mount to /home/lkuta/.local/share/containers/storage/overlay/cbb0b23158e8e9a782423ca63117dc09cf80da6e42af304dd817d625e2f53aa2/merged, mount_data=",lowerdir=/home/lkuta/.local/share/containers/storage/overlay/l/GKLDWZ3H25DSHSWEX37P657IJQ:/home/lkuta/.local/share/containers/storage/overlay/l/ONIX2V6F2BK5RRDYOXQJZ2V5T6:/home/lkuta/.local/share/containers/storage/overlay/l/VLIZSSRUYDMGZN55TZ2I73TIIA:/home/lkuta/.local/share/containers/storage/overlay/l/K26TWS3MHOW3UAQKPHTJL52MEL,upperdir=/home/lkuta/.local/share/containers/storage/overlay/cbb0b23158e8e9a782423ca63117dc09cf80da6e42af304dd817d625e2f53aa2/diff,workdir=/home/lkuta/.local/share/containers/storage/overlay/cbb0b23158e8e9a782423ca63117dc09cf80da6e42af304dd817d625e2f53aa2/work,userxattr": invalid argument
ERRO exit status 125  

Output of rpm -q buildah or apt list buildah:

buildah/unknown,now 100:1.20.0-3 amd64 [installed]
buildah/unknown 100:1.20.0-3 arm64
buildah/unknown 100:1.20.0-3 armhf
buildah/unknown 100:1.20.0-3 s390x

Output of buildah version:

Version:         1.20.0
Go Version:      go1.15.2
Image Spec:      1.0.1-dev
Runtime Spec:    1.0.2-dev
CNI Spec:        0.4.0
libcni Version:  
image Version:   5.10.5
Git Commit:      
Built:           Thu Jan  1 01:00:00 1970
OS/Arch:         linux/amd64

*Output of `cat /etc/release`:**

DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=20.10
DISTRIB_CODENAME=groovy
DISTRIB_DESCRIPTION="Ubuntu 20.10"
NAME="Ubuntu"
VERSION="20.10 (Groovy Gorilla)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.10"
VERSION_ID="20.10"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=groovy
UBUNTU_CODENAME=groovy

Output of uname -a:

Linux nblkuta 5.8.0-48-generic #54-Ubuntu SMP Fri Mar 19 14:25:20 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Output of cat /etc/containers/storage.conf:

# This file is is the configuration file for all tools
# that use the containers/storage library.
# See man 5 containers-storage.conf for more information
# The "container storage" table contains all of the server options.
[storage]

# Default Storage Driver, Must be set for proper operation.
driver = "overlay"

# Temporary storage location
runroot = "/run/containers/storage"

# Primary Read/Write location of container storage
graphroot = "/var/lib/containers/storage"

# Storage path for rootless users
#
# rootless_storage_path = "$HOME/.local/share/containers/storage"

[storage.options]
# Storage options to be passed to underlying storage drivers

# AdditionalImageStores is used to pass paths to additional Read/Only image stores
# Must be comma separated list.
additionalimagestores = [
]

# Remap-UIDs/GIDs is the mapping from UIDs/GIDs as they should appear inside of
# a container, to the UIDs/GIDs as they should appear outside of the container,
# and the length of the range of UIDs/GIDs.  Additional mapped sets can be
# listed and will be heeded by libraries, but there are limits to the number of
# mappings which the kernel will allow when you later attempt to run a
# container.
#
# remap-uids = 0:1668442479:65536
# remap-gids = 0:1668442479:65536

# Remap-User/Group is a user name which can be used to look up one or more UID/GID
# ranges in the /etc/subuid or /etc/subgid file.  Mappings are set up starting
# with an in-container ID of 0 and then a host-level ID taken from the lowest
# range that matches the specified name, and using the length of that range.
# Additional ranges are then assigned, using the ranges which specify the
# lowest host-level IDs first, to the lowest not-yet-mapped in-container ID,
# until all of the entries have been used for maps.
#
# remap-user = "containers"
# remap-group = "containers"

# Root-auto-userns-user is a user name which can be used to look up one or more UID/GID
# ranges in the /etc/subuid and /etc/subgid file.  These ranges will be partitioned
# to containers configured to create automatically a user namespace.  Containers
# configured to automatically create a user namespace can still overlap with containers
# having an explicit mapping set.
# This setting is ignored when running as rootless.
# root-auto-userns-user = "storage"
#
# Auto-userns-min-size is the minimum size for a user namespace created automatically.
# auto-userns-min-size=1024
#
# Auto-userns-max-size is the minimum size for a user namespace created automatically.
# auto-userns-max-size=65536

[storage.options.overlay]
# ignore_chown_errors can be set to allow a non privileged user running with
# a single UID within a user namespace to run containers. The user can pull
# and use any image even those with multiple uids.  Note multiple UIDs will be
# squashed down to the default uid in the container.  These images will have no
# separation between the users in the container. Only supported for the overlay
# and vfs drivers.
#ignore_chown_errors = "false"

# Path to an helper program to use for mounting the file system instead of mounting it
# directly.
#mount_program = "/usr/bin/fuse-overlayfs"

# mountopt specifies comma separated list of extra mount options
mountopt = "nodev,metacopy=on"

# Set to skip a PRIVATE bind mount on the storage home directory.
# skip_mount_home = "false"

# Size is used to set a maximum size of the container image.
# size = ""

# ForceMask specifies the permissions mask that is used for new files and
# directories.
#
# The values "shared" and "private" are accepted.
# Octal permission masks are also accepted.
#
#  "": No value specified.
#     All files/directories, get set with the permissions identified within the
#     image.
#  "private": it is equivalent to 0700.
#     All files/directories get set with 0700 permissions.  The owner has rwx
#     access to the files. No other users on the system can access the files.
#     This setting could be used with networked based homedirs.
#  "shared": it is equivalent to 0755.
#     The owner has rwx access to the files and everyone else can read, access
#     and execute them. This setting is useful for sharing containers storage
#     with other users.  For instance have a storage owned by root but shared
#     to rootless users as an additional store.
#     NOTE:  All files within the image are made readable and executable by any
#     user on the system. Even /etc/shadow within your image is now readable by
#     any user.
#
#   OCTAL: Users can experiment with other OCTAL Permissions.
#
#  Note: The force_mask Flag is an experimental feature, it could change in the
#  future.  When "force_mask" is set the original permission mask is stored in
#  the "user.containers.override_stat" xattr and the "mount_program" option must
#  be specified. Mount programs like "/usr/bin/fuse-overlayfs" present the
#  extended attribute permissions to processes within containers rather then the
#  "force_mask"  permissions.
#
# force_mask = ""

[storage.options.thinpool]
# Storage Options for thinpool

# autoextend_percent determines the amount by which pool needs to be
# grown. This is specified in terms of % of pool size. So a value of 20 means
# that when threshold is hit, pool will be grown by 20% of existing
# pool size.
# autoextend_percent = "20"

# autoextend_threshold determines the pool extension threshold in terms
# of percentage of pool size. For example, if threshold is 60, that means when
# pool is 60% full, threshold has been hit.
# autoextend_threshold = "80"

# basesize specifies the size to use when creating the base device, which
# limits the size of images and containers.
# basesize = "10G"

# blocksize specifies a custom blocksize to use for the thin pool.
# blocksize="64k"

# directlvm_device specifies a custom block storage device to use for the
# thin pool. Required if you setup devicemapper.
# directlvm_device = ""

# directlvm_device_force wipes device even if device already has a filesystem.
# directlvm_device_force = "True"

# fs specifies the filesystem type to use for the base device.
# fs="xfs"

# log_level sets the log level of devicemapper.
# 0: LogLevelSuppress 0 (Default)
# 2: LogLevelFatal
# 3: LogLevelErr
# 4: LogLevelWarn
# 5: LogLevelNotice
# 6: LogLevelInfo
# 7: LogLevelDebug
# log_level = "7"

# min_free_space specifies the min free space percent in a thin pool require for
# new device creation to succeed. Valid values are from 0% - 99%.
# Value 0% disables
# min_free_space = "10%"

# mkfsarg specifies extra mkfs arguments to be used when creating the base
# device.
# mkfsarg = ""

# metadata_size is used to set the `pvcreate --metadatasize` options when
# creating thin devices. Default is 128k
# metadata_size = ""

# Size is used to set a maximum size of the container image.
# size = ""

# use_deferred_removal marks devicemapper block device for deferred removal.
# If the thinpool is in use when the driver attempts to remove it, the driver
# tells the kernel to remove it as soon as possible. Note this does not free
# up the disk space, use deferred deletion to fully remove the thinpool.
# use_deferred_removal = "True"

# use_deferred_deletion marks thinpool device for deferred deletion.
# If the device is busy when the driver attempts to delete it, the driver
# will attempt to delete device every 30 seconds until successful.
# If the program using the driver exits, the driver will continue attempting
# to cleanup the next time the driver is used. Deferred deletion permanently
# deletes the device and all data stored in device will be lost.
# use_deferred_deletion = "True"

# xfs_nospace_max_retries specifies the maximum number of retries XFS should
# attempt to complete IO when ENOSPC (no space) error is returned by
# underlying storage device.
# xfs_nospace_max_retries = "0"
urfin78 commented 3 years ago

It's also broken in the current virtual environment ubuntu-latest or ubuntu-20.04 for github-actions as it provides buildah 1.20.0: https://github.com/actions/virtual-environments/releases/tag/ubuntu20%2F20210330.1

divyansh42 commented 3 years ago

Here is a workaround we are using in GitHub Actions, as per buildah troubleshooting: https://github.com/redhat-actions/buildah-build/issues/45#issuecomment-812043531

TomSweeneyRedHat commented 3 years ago

@Divyansh42 thank you very much for the pointer. For others that hop into this thread, here's the solution from the link @Divyansh42 provided. If you want more details, head over there.

Install and configure fuse-overlayfs.

    Install the fuse-overlayfs package for your Linux Distribution.
    Add mount_program = "/usr/bin/fuse-overlayfs" under [storage.options] in your ~/.config/containers/storage.conf file.
tetchel commented 3 years ago

Well, a lot of users are going to continue to hit this upgrading from 1.19 to 1.20.

Is there any chance we can set fuse-overlayfs as the Ubuntu default? I have only seen the problem on Ubuntu; I don't know what change is causing it so that may or may not be the set of users affected.

This looks like https://github.com/containers/buildah/issues/1745 though that is a rather old issue

qtekk commented 3 years ago

export STORAGE_OPTS="overlay.mount_program=/usr/bin/fuse-overlayfs" - this fixed my issue.

https://github.com/containers/buildah/issues/3120#issuecomment-812153062 didn't work for me (missing ~/.config/containers/storage.conf file)