containers / common

Location for shared common files in github.com/containers repos.
Apache License 2.0
182 stars 188 forks source link

Logo Visibility Issue in GitHub Dark Theme #1791

Open alexandear opened 8 months ago

alexandear commented 8 months ago

It might seem minor, but I spotted the "containers" logo in the containers/.github repo that features black text on transparent backgrounds. Unfortunately, these don't display properly when I view the "containers" organization in GitHub's dark theme.

Screenshots

For instance, here's a screenshot to illustrate:

image

Compare the same screenshot but in the light theme:

image

Proposed solution

One of the solutions is to use separate logos for the Dark and Light theme. See https://github.blog/changelog/2022-05-19-specify-theme-context-for-images-in-markdown-beta/

rhatdan commented 8 months ago

@mairin WDYT?

mairin commented 8 months ago

@rhatdan ill come up with a fix