containers / common

Location for shared common files in github.com/containers repos.
Apache License 2.0
183 stars 189 forks source link

pasta: use new --map-guest-addr option #2136

Closed Luap99 closed 3 weeks ago

Luap99 commented 1 month ago

see commits, I still need to test and integrate this into podman

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/common/blob/main/OWNERS)~~ [Luap99] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Luap99 commented 1 month ago

@mheon PTAL, podman PR: https://github.com/containers/podman/pull/23791

cc @sbrivio-rh @dgibson

mheon commented 4 weeks ago

LGTM on my end

Luap99 commented 3 weeks ago

@mheon PTAL again as I added some more changes

Passes podman CI https://github.com/containers/podman/pull/23791 so this is good to merge I would say

Luap99 commented 3 weeks ago

@mheon @rhatdan PTAL

mheon commented 3 weeks ago

LGTM

mheon commented 3 weeks ago

/lgtm