search

containers / common

Location for shared common files in github.com/containers repos.
Apache License 2.0
191 stars 200 forks source link

Export portions of Copier #2164

Closed baude closed 1 month ago

baude commented 1 month ago

To support artifact handling, we need to export some of the methods for copier. The Copy and Close method have been exported. In addition, a new constructor that is exported was created so we could introduce a different SystemContext for artifacts.

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/common/blob/main/OWNERS)~~ [baude] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/common/blob/main/OWNERS)~~ [baude] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rhatdan commented 1 month ago

/lgtm

mtrmac commented 1 month ago

None of the review comments were actually resolved AFAICS? I can see good reasons for not acting of them, but I don’t see any benefit of not representing the decision correctly.

mtrmac commented 1 month ago

For the record, this continues in #2173.