search

containers / common

Location for shared common files in github.com/containers repos.
Apache License 2.0
191 stars 200 forks source link

Export Copier to support OCI artifacts #2173

Closed baude closed 1 month ago

baude commented 1 month ago

To support OCI artifacts in Podman, we need to export the Copier type and create an exported constructor (NewCopier). Additionally, the actual copy and close methods are now exported.

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/common/blob/main/OWNERS)~~ [baude] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rhatdan commented 1 month ago

LGTM

mtrmac commented 1 month ago

For the record, compare earlier https://github.com/containers/common/pull/2164 .

mheon commented 1 month ago

/lgtm