containers / common

Location for shared common files in github.com/containers repos.
Apache License 2.0
191 stars 200 forks source link

pkg/subscriptions: use securejoin for the container path #2185

Closed Luap99 closed 1 month ago

Luap99 commented 1 month ago

If we join a path from the container image we must always use securejoin to prevent us from following a symlink onto the host.

Fixes CVE-2024-9341

Luap99 commented 1 month ago

@mheon @mtrmac PTAL

mheon commented 1 month ago

LGTM

kwilczynski commented 1 month ago

/approve /lgtm

openshift-ci[bot] commented 1 month ago

@kwilczynski: changing LGTM is restricted to collaborators

In response to [this](https://github.com/containers/common/pull/2185#issuecomment-2386401758): >/approve >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/common/blob/main/OWNERS)~~ [Luap99] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment