search

containers / common

Location for shared common files in github.com/containers repos.
Apache License 2.0
193 stars 201 forks source link

Revert "Move fuse-overlayfs to suggests" for all Fedoras #2206

Closed debarshiray closed 1 month ago

debarshiray commented 1 month ago

Commit 5ad221daa4d8d182 ("Revert \"Move fuse-overlayfs to suggests\" for Fedora 40 and older") restored the dependency on fuse-overlayfs for Fedora 40 and older to not disrupt stable Fedora releases by breaking backwards compatibility with existing containers.

Fedora completely ignores Suggests by default [1]. So, listing anything as Suggests is as good as not mentioning it at all, unless it's intended for tools and users who specifically respect it.

It turns out that there are important use-cases where the Linux kernel's overlay file system doesn't work, and one could really benefit from having fuse-overlayfs(1). A container cannot use an overlayfs when the underlying file system is also an overlayfs, such as on the Fedora Workstation live media, or a network file system.

Therefore, it's worth restoring the dependency on all Fedora releases to cover these use-cases.

As suggested by Giuseppe Scrivano.

This reverts Fedora commit 447945e59a01cb6715ed2a21877d45bf0b91ef67 for all Fedora releases.

[1] https://docs.fedoraproject.org/en-US/packaging-guidelines/WeakDependencies/

Fixes: https://github.com/coreos/fedora-coreos-tracker/issues/1749 Fixes: https://github.com/containers/toolbox/issues/1512 Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2299284

debarshiray commented 1 month ago

/cc @giuseppe

I didn't touch any Fedora derivatives, because I assume that it needs further discussion.

debarshiray commented 1 month ago

Fedora Rawhide scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=124928109

Fedora 41 scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=124928112

debarshiray commented 1 month ago

Downstream Fedora pull requests: https://src.fedoraproject.org/rpms/containers-common/pull-request/41 https://src.fedoraproject.org/rpms/containers-common/pull-request/42

travier commented 1 month ago

Thanks for doing this. We'll need a Bugzilla and a freeze exception for F41.

travier commented 1 month ago

Ah we already have both: https://bugzilla.redhat.com/show_bug.cgi?id=2299284

rhatdan commented 1 month ago

/approve /lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: debarshiray, rhatdan, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/common/blob/main/OWNERS)~~ [rhatdan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
debarshiray commented 1 month ago

Thanks for the quick review, @rhatdan !