containers / common

Location for shared common files in github.com/containers repos.
Apache License 2.0
193 stars 201 forks source link

rpm/update-config-files: zstd:chunked not enabled in Fedora yet #2208

Closed travier closed 1 month ago

travier commented 1 month ago

See: https://fedoraproject.org/wiki/Changes/zstd:chunked See: https://pagure.io/fesco/issue/3252 See: https://github.com/containers/common/pull/2048 See: https://src.fedoraproject.org/rpms/containers-common/c/9f4dd38589309fbc189eac94367f520c105c3c1c?branch=f41

mheon commented 1 month ago

Sure, LGTM. We threw this in an RPM patch so the latest F41 builds are fine.

Luap99 commented 1 month ago

@lsm5 PTAL

rhatdan commented 1 month ago

LGTM

travier commented 1 month ago

Sure, LGTM. We threw this in an RPM patch so the latest F41 builds are fine.

Yes, saw that earlier. I was thinking "let's push it upstream so that we don't forget it".

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/common/blob/main/OWNERS)~~ [Luap99] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
lsm5 commented 1 month ago

sorry for the late response. LGTM

cgwalters commented 1 month ago

Additional followup in https://github.com/containers/common/pull/2213