search

containers / common

Location for shared common files in github.com/containers repos.
Apache License 2.0
193 stars 201 forks source link

[skip-ci][v0.60] RPM: do not set zstd:chunked default anywhere #2211

Closed lsm5 closed 3 weeks ago

lsm5 commented 1 month ago

Fixed in main with #2208 and #2213.

openshift-ci[bot] commented 1 month ago

@travier: changing LGTM is restricted to collaborators

In response to [this](https://github.com/containers/common/pull/2211#pullrequestreview-2385532218): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
travier commented 1 month ago

@lsm5 Can you remove the @travier from the commit message please? Otherwise I'll get mentioned every time someone pushes this commit somewhere on GitHub. Thanks

lsm5 commented 1 month ago

@lsm5 Can you remove the @travier from the commit message please? Otherwise I'll get mentioned every time someone pushes this commit somewhere on GitHub. Thanks

done. sorry about the noise.

openshift-ci[bot] commented 1 month ago

@travier: changing LGTM is restricted to collaborators

In response to [this](https://github.com/containers/common/pull/2211#pullrequestreview-2389175900): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
mheon commented 3 weeks ago

LGTM

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, lsm5, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/common/blob/v0.60/OWNERS)~~ [edsantiago] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment