search

containers / common

Location for shared common files in github.com/containers repos.
Apache License 2.0
193 stars 201 forks source link

Revert PR 2202 #2227

Closed Luap99 closed 2 weeks ago

Luap99 commented 2 weeks ago

We suspect this is causing issue sin podman as multi arch builds are no longer working as the pulling in parallel seems to break

# Error: [linux/s390x]: creating build container: looking up a just-pulled image: reference "[vfs@/var/tmp/buildah_tests.6dq4pu/root+/var/tmp/buildah_tests.6dq4pu/runroot]docker.io/library/alpine@sha256:43955d6857268cc948ae9b370b221091057de83c4962da0826f9a2bdc9bd6b44" does not resolve to an image ID: identifier is not an image

https://github.com/containers/podman/pull/24447

Draft until we now we will not fix it in time for the 5.3 release and I confirmed this fixes the podman regression

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/common/blob/main/OWNERS)~~ [Luap99] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mtrmac commented 2 weeks ago

Alternatively, consider merging https://github.com/containers/image/pull/2609 + https://github.com/containers/common/pull/2209 . I’d prefer that. Test running in https://github.com/containers/podman/pull/24462 .

Or, reverting only https://github.com/containers/common/commit/aa722efd5cabed0e9f3e2ebae7b1cf8932f50e81 should be sufficient per my manual testing (but reverting the whole PR as a unit is, of course, entirely fair.)