search

containers / common

Location for shared common files in github.com/containers repos.
Apache License 2.0
193 stars 201 forks source link

update ci image to f41 #2246

Closed Luap99 closed 5 days ago

Luap99 commented 1 week ago
openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/common/blob/main/OWNERS)~~ [Luap99] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Luap99 commented 1 week ago 
Writing manifest to image destination
    push_test.go:60: 
            Error Trace:    /var/tmp/go/src/github.com/containers/common/libimage/push_test.go:60
            Error:          "[0xc0003b2c80]" should have 2 item(s), but has 1
            Test:           TestPush
            Messages:       there should only be two images (alpine in Docke/OCI)
--- FAIL: TestPush (1.88s)

seems to be consistent

Luap99 commented 5 days ago

CI issue was fixed in https://github.com/containers/common/pull/2250 so this should pass now

@edsantiago @mheon @rhatdan PTAL

edsantiago commented 5 days ago

Oh, I missed #2250. Nice job of futureproofing.

LGTM

edsantiago commented 5 days ago

/lgtm