search

containers / composefs-rs

Rust library for the composefs filesystem
Apache License 2.0
7 stars 2 forks source link

dumpfile_parse: New module #33

Closed cgwalters closed 1 week ago

cgwalters commented 1 week ago

This was imported from the dumpfile.rs from https://github.com/containers/composefs/commit/738793aac459fc735790870fcf686a09cd1a151e

Per discussion it's generally useful to be able to fully parse a composefs file back into a dumpfile.

cgwalters commented 1 week ago

OK addressed the bugs, this one should be in good shape now!

I don't think it makes sense to just drop this code in without attempting to integrate it. As it stands, the only thing that you can do with this structure after you read it in is to print it back out again. We should discuss this, though.

Well I dunno, there's quite a collection of stuff in this repository already, I don't think we're in any state to be saying we're committing to long term APIs.

I agree we should try to use this, but given that I think others will want to be able to parse composefs blobs, I think the code is valuable and again I see this as part of agreeing to merge our two projects.

cgwalters commented 1 week ago

OK right, this has the same issue that motivated the CI changes in https://github.com/containers/composefs-rs/pull/24 (Edit: except to be clear it's not that we need the shared libraries, but we need the binaries, which we should definitely try to package for ubuntu/debian too etc.) I pulled those two changes into this PR (but not the change to link to the shared library).