containers / conmon-rs

An OCI container runtime monitor written in Rust
Apache License 2.0
183 stars 42 forks source link

Change default from localhost to 127.0.0.1 #2391

Closed bitoku closed 1 month ago

bitoku commented 1 month ago

What type of PR is this?

/kind other

What this PR does / why we need it:

This PR changes the default tracing endpoint to 127.0.0.1 to align with the cri-o change.

Which issue(s) this PR fixes:

Fixes a part of https://github.com/cri-o/cri-o/issues/7448

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Use 127.0.0.1 as the new default for tracing endpoint.
codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.89%. Comparing base (4e0f474) to head (105eea4). Report is 696 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2391 +/- ## =========================================== + Coverage 37.53% 47.89% +10.35% =========================================== Files 15 121 +106 Lines 1268 4042 +2774 Branches 414 833 +419 =========================================== + Hits 476 1936 +1460 - Misses 526 1602 +1076 - Partials 266 504 +238 ```
kwilczynski commented 1 month ago

/approve /lgtm

openshift-ci[bot] commented 1 month ago

@kwilczynski: changing LGTM is restricted to collaborators

In response to [this](https://github.com/containers/conmon-rs/pull/2391#issuecomment-2301282806): >/approve >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bitoku, kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/conmon-rs/blob/main/OWNERS)~~ [saschagrunert] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
saschagrunert commented 1 month ago

@bitoku CI seems to hang, do you mind a rebase?

kwilczynski commented 1 month ago

/close

openshift-ci[bot] commented 1 month ago

@kwilczynski: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to [this](https://github.com/containers/conmon-rs/pull/2391#issuecomment-2311923070): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kwilczynski commented 1 month ago

Can't /close and /reopen to kick the tires on the CI. :smile: