containers / conmon-rs

An OCI container runtime monitor written in Rust
Apache License 2.0
183 stars 42 forks source link

Add support for crun `--log-level` #2401

Closed saschagrunert closed 3 weeks ago

saschagrunert commented 4 weeks ago

What type of PR is this?

/kind feature

What this PR does / why we need it:

We now support the new crun log level flags.

Which issue(s) this PR fixes:

Refers to https://github.com/containers/crun/issues/1525

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Added support for crun log level flags, which requires at least crun v1.16.2.
saschagrunert commented 4 weeks ago

@kwilczynski PTAL

codecov-commenter commented 4 weeks ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.64%. Comparing base (4e0f474) to head (1969ca8). Report is 702 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2401 +/- ## =========================================== + Coverage 37.53% 47.64% +10.10% =========================================== Files 15 121 +106 Lines 1268 4007 +2739 Branches 414 830 +416 =========================================== + Hits 476 1909 +1433 - Misses 526 1590 +1064 - Partials 266 508 +242 ```
kwilczynski commented 4 weeks ago

/approve /lgtm

openshift-ci[bot] commented 4 weeks ago

@kwilczynski: changing LGTM is restricted to collaborators

In response to [this](https://github.com/containers/conmon-rs/pull/2401#issuecomment-2324551868): >/approve >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
saschagrunert commented 3 weeks ago

@kwilczynski I invited you to become a collaborator to this project. Do you mind accepting and trying an /lgtm again?

kwilczynski commented 3 weeks ago

/approve /lgtm

saschagrunert commented 3 weeks ago

@kwilczynski PTAL again

kwilczynski commented 3 weeks ago

/approve /lgtm

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/conmon-rs/blob/main/OWNERS)~~ [saschagrunert] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment