containers / conmon-rs

An OCI container runtime monitor written in Rust
Apache License 2.0
190 stars 43 forks source link

Print child ID and error if command failed #2413

Closed saschagrunert closed 2 months ago

saschagrunert commented 2 months ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This helps to increase the verbosity around error handling.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None
codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.23%. Comparing base (4e0f474) to head (1cf5264). Report is 726 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2413 +/- ## =========================================== + Coverage 37.53% 63.23% +25.69% =========================================== Files 15 121 +106 Lines 1268 4007 +2739 Branches 414 830 +416 =========================================== + Hits 476 2534 +2058 - Misses 526 1473 +947 + Partials 266 0 -266 ```
saschagrunert commented 2 months ago

Rebased

kwilczynski commented 2 months ago

/approve /lgtm

saschagrunert commented 2 months ago

Rebased again.

kwilczynski commented 2 months ago

/approve /lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/conmon-rs/blob/main/OWNERS)~~ [saschagrunert] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment